-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: link to next docs and vice versa #1438
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1438 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2165 2165
Lines 237132 237132
Branches 1016 1016
=======================================
Hits 236242 236242
Misses 869 869
Partials 21 21 |
@matthewmayer Good point. This PR is more about linking the different versions together/making them accessible from our main website, so I created a new issue (#1456) for that to keep track of it. |
Co-authored-by: Shinigami <[email protected]>
I created some preview deployments:
|
Looked into the preview deployments and I like them all 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is now MUCH better 👍
Will approve after rebased
This reverts commit 93df944.
It doesn't pass our CI, so I reverted it. |
🤣 no f*cking way, out TESTS are blocking it 🤣 |
Well, we could omit the tests... 🤣 |
Na, lets just upgrade when we move to |
Currently the https://next.fakerjs.dev/ page does not show any hints that it isn't the current version.
This PR changes the version number to
Next
and adds a link to the latest released page.