-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add male first names starting with Z to id_ID #1424
Conversation
accidently click close PR instead of ready for review 😄 |
Test failing on
Looks like it's unrelated to this PR. |
Yes, you are right. I'll try to rerun the test. Propably a network connection error or something like that. |
Hm, that wasn't the issue. I remember that we restricted access to each job individually. Might be an issue in the workflow config (but unrelated to this PR). @Shinigami92 or @ST-DDT might you to take a look into this? |
@fzn0x could you please add a minimal description to the PR? Would be highly appreciated. |
Added :) ! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 99.62% 99.61% -0.01%
==========================================
Files 2166 2166
Lines 237442 237445 +3
Branches 1042 1040 -2
==========================================
- Hits 236545 236538 -7
- Misses 876 886 +10
Partials 21 21
|
I saw that we are missing starts with Z for male first name, but actually there is
It is Zaki, Zakir, and Zulfikar, it is commonly used for millenials muslims male first name.
There's more, but I probably would added these 3 because it is the most common used.