fix(image): properly lock loremflickr.com images #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
approved these changes
Sep 26, 2022
ST-DDT
added
c: bug
|
Your commit is marked as "not verified". Did you forget to sign them? |
ST-DDT
requested changes
Sep 26, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2163 2163
Lines 241306 241306
Branches 1017 1017
=======================================
Hits 240399 240399
Misses 886 886
Partials 21 21
|
wesen
force-pushed
the
fix/image/properly-lock-loremflickr-images
branch
from
c49ee33
to
9b9f839
Compare
ST-DDT
requested changes
Sep 26, 2022
https://loremflickr.com requires the lock= parameter to be given to serve an identical image (at least as long as its cache is not updated).
wesen
force-pushed
the
fix/image/properly-lock-loremflickr-images
branch
from
9b9f839
to
b94d9ce
Compare
ST-DDT
approved these changes
Sep 26, 2022
import-brain
approved these changes
Sep 26, 2022
Shinigami92
approved these changes
Sep 26, 2022
xDivisionByZerox
approved these changes
Sep 27, 2022
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://loremflickr.com requires the lock= parameter to be given
to serve an identical image (at least as long as its cache is not
updated).