Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(address): update deprecation warning #1314

Merged
merged 2 commits into from
Aug 29, 2022
Merged

refactor(address): update deprecation warning #1314

merged 2 commits into from
Aug 29, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module labels Aug 29, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Aug 29, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 29, 2022 07:39
@Shinigami92 Shinigami92 self-assigned this Aug 29, 2022
@Shinigami92 Shinigami92 requested review from a team August 29, 2022 07:42
@codecov
Copy link

codecov bot commented Aug 29, 2022 •
edited
Loading

Codecov Report

Merging #1314 (03f8f9f) into main (f522cef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 03f8f9f differs from pull request most recent head 1be6c59. Consider uploading reports for the commit 1be6c59 to get more accurate results

@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2160     2160           
  Lines      240454   240455    +1     
  Branches     1005     1006    +1     
=======================================
+ Hits       239549   239551    +2     
+ Misses        884      883    -1     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/address/index.ts 99.81% <100.00%> (+<0.01%) ⬆️
src/modules/finance/index.ts 100.00% <0.00%> (+0.23%) ⬆️

@Shinigami92 Shinigami92 enabled auto-merge (squash) August 29, 2022 07:49
@Shinigami92 Shinigami92 merged commit 8dae00d into main Aug 29, 2022
@Shinigami92 Shinigami92 deleted the fix-depr-msg branch September 29, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @xDivisionByZerox