fix(datatype): unintentional hex breaking change #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import-brain
added
c: bug
xDivisionByZerox
requested changes
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 2160 2160
Lines 240440 240454 +14
Branches 1008 1006 -2
==========================================
+ Hits 239546 239550 +4
- Misses 873 883 +10
Partials 21 21
|
Co-authored-by: Leyla Jähnig <[email protected]>
xDivisionByZerox
previously approved these changes
Aug 27, 2022
Shinigami92
requested changes
Aug 27, 2022
import-brain
force-pushed
the
fix/hexadecimal_break
branch
from
ae1137d
to
3a69ce9
Compare
|
@xDivisionByZerox Thank you for the refactoring help, I missed those instances of string manipulation. |
Shinigami92
approved these changes
Aug 28, 2022
xDivisionByZerox
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a BREAKING CHANGE introduced in #1238.