Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(name): add sexType method #1289

Merged
merged 4 commits into from
Aug 22, 2022
Merged

feat(name): add sexType method #1289

merged 4 commits into from
Aug 22, 2022

Conversation

Shinigami92
Copy link
Member

Requested by @ST-DDT via #776 (comment)

This function is just a helper for users that want to use faker instead of plain TS

@Shinigami92 Shinigami92 added c: feature Request for new feature m: person Something is referring to the person module labels Aug 19, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Aug 19, 2022
@Shinigami92 Shinigami92 self-assigned this Aug 19, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 19, 2022 12:47
@Shinigami92 Shinigami92 requested review from ST-DDT and a team August 19, 2022 12:47
ST-DDT
ST-DDT requested changes Aug 19, 2022
View reviewed changes
src/modules/name/index.ts Outdated Show resolved Hide resolved
test/name.spec.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 19, 2022 •
edited
Loading

Codecov Report

Merging #1289 (18267a3) into main (23adcc0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 18267a3 differs from pull request most recent head c0e57d0. Consider uploading reports for the commit c0e57d0 to get more accurate results

@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2160     2160           
  Lines      240421   240431   +10     
  Branches     1004     1009    +5     
=======================================
+ Hits       239522   239555   +33     
+ Misses        878      855   -23     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/name/index.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 99.77% <0.00%> (-0.23%) ⬇️
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Aug 19, 2022
@ST-DDT ST-DDT requested a review from a team August 21, 2022 20:12
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 22, 2022 07:58
@Shinigami92 Shinigami92 merged commit f684a14 into main Aug 22, 2022
@xDivisionByZerox xDivisionByZerox mentioned this pull request Aug 26, 2022
Merged
@ST-DDT ST-DDT mentioned this pull request Sep 8, 2022
Closed
@Shinigami92 Shinigami92 deleted the person-sex-type branch September 29, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: feature Request for new feature m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @import-brain