-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<?>: split download size in half #1287
Conversation
this needs to be merged with generate locale files
f028fe2
to
38a03bb
Compare
Just out of the interest: what's the benefit of having locales as json vs ts? |
Most important one: splitting the package size into HALF! Second important one: having simpler files to manage |
Closing these experiments for now |
@Shinigami92 Do you still need the branch? If not, please delete it. Commit-ID: 4203c3d |
Yes, please do not delete them right now so we have a copy and look into it if needed |
EXPERIMENTAL
What is this?:
src/locales
were converted into.json
filessrc/locales/<locale>.json
file to require/import them (for at-dev time)dist/locales/<locale>.json
and are required/imported by cjs and esm from same source (for at-bundled time)Open TODOs:
ar
andur
)Later?
To review this PR, I tried as best as I could to separate all commits