test(internet): fix username expecting numbers with length 2

[xDivisionByZerox]

Found in #1059.

The implementation of internet.username() uses the provided first and last name and can append a random number to them. This number is between 0 and 99 (inclusive).

faker/src/modules/internet/index.ts

Lines 142 to 145 in 93ef876

	result = `${firstName}${this.faker.helpers.arrayElement([
	'.',
	'_',
	])}${lastName}${this.faker.datatype.number(99)}`;

The test on the other hand side uses a regex that expects the email to have a number (if existing) that has at least a length of 2.

This PR fixes the described issue.

[codecov]

Codecov Report

Merging #1284 (3830368) into main (93ef876) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2154     2154              
  Lines      239914   239914              
  Branches     1003     1002       -1     
==========================================
- Hits       239015   239014       -1     
- Misses        878      879       +1     
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/finance/index.ts	99.77% <0.00%> (-0.23%)	⬇️

[Shinigami92]

Please use the new PR title naming convention: https://github.com/faker-js/faker/blob/main/CONTRIBUTING.md#committing

[Shinigami92]

Maybe it wanted to generate 00-09?
Or why did this never failed?

[ST-DDT]

Or why did this never failed?

Because it doesn't generate random numbers in the test currently.

[xDivisionByZerox]

Maybe it wanted to generate 00-09? Or why did this never failed?

It did fail at one point in #1059. That's why that PR has a dedicated commit to fix that issue. But since this issue can potentially hit any other contributor at any time I wanted to take it out of that PR.

Commit ref.