Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(company.name): deprecate format parameter #1212

Merged
merged 1 commit into from
Jul 30, 2022
Merged

refactor(company.name): deprecate format parameter #1212

merged 1 commit into from
Jul 30, 2022

Conversation

Minozzzi
Copy link
Contributor

@Minozzzi Minozzzi commented Jul 30, 2022 •
edited
Loading

Hello guys. I added deprecated workflow to parameter of company.name.
I hope that I have contribute correctly 😀

Issue: #1178

@Minozzzi Minozzzi requested a review from a team as a code owner July 30, 2022 16:37
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #1212 (6b91872) into main (a65f1a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2153     2153           
  Lines      236493   236502    +9     
  Branches      976      980    +4     
=======================================
+ Hits       235605   235635   +30     
+ Misses        867      846   -21     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/company/index.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 99.31% <0.00%> (-0.69%) ⬇️
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

@import-brain import-brain added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module labels Jul 30, 2022
@import-brain import-brain linked an issue Jul 30, 2022 that may be closed by this pull request
Deprecate company.name index parameter #1178
Closed
@import-brain import-brain added this to the v7 - Current Major milestone Jul 30, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Jul 30, 2022
@ST-DDT ST-DDT requested review from a team July 30, 2022 17:47
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Jul 30, 2022
@xDivisionByZerox xDivisionByZerox changed the title refactor(company): add deprecated workflow to parameter of company.name() refactor(company.name): deprecate format parameter Jul 30, 2022
@xDivisionByZerox
Copy link
Member

@Minozzzi I changed the PR title. Are you fine with that?

@Shinigami92 Shinigami92 merged commit aedd7b8 into faker-js:main Jul 30, 2022
@Minozzzi
Copy link
Contributor Author

@Minozzzi I changed the PR title. Are you fine with that?

Thanks @xDivisionByZerox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Minozzzi Minozzzi

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

Deprecate company.name index parameter
5 participants
@Minozzzi @xDivisionByZerox @ST-DDT @Shinigami92 @import-brain