Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bug-report-template): new design #1205

Merged
merged 27 commits into from
Aug 4, 2022

Conversation

xDivisionByZerox
Copy link
Member

This PR completely reworks the bug-report issue template.
This should lead to an overall better experience for the person creating an issue in the bug category as well as the person answering the to it.

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner July 28, 2022 07:34
@xDivisionByZerox
Copy link
Member Author

I'm not sure how to label this. 🤷‍♀️

@xDivisionByZerox xDivisionByZerox changed the title workflow(bug-report): new version chore(bug-report): new version Jul 28, 2022
@xDivisionByZerox xDivisionByZerox changed the title chore(bug-report): new version chore(bug-report-template): new version Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1205 (3f2a599) into main (04b2ec4) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2155     2155              
  Lines      236831   236831              
  Branches      980      984       +4     
==========================================
+ Hits       235943   235967      +24     
+ Misses        867      843      -24     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

@xDivisionByZerox xDivisionByZerox force-pushed the workflow/issue-templates/bug-report branch from e53ccb3 to 5d3b54d Compare July 28, 2022 07:45
@xDivisionByZerox xDivisionByZerox changed the title chore(bug-report-template): new version chore(bug-report-template): new design Jul 28, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team July 28, 2022 10:08
@xDivisionByZerox xDivisionByZerox force-pushed the workflow/issue-templates/bug-report branch from caff78d to 7e8f5e3 Compare July 28, 2022 17:34
@xDivisionByZerox
Copy link
Member Author

I've provided a working example on my fork of the project. You create issues with this template here.
This is mainly because the relative links down work in the yaml preview, but they do as soon as the template is merged.

@xDivisionByZerox xDivisionByZerox added the c: infra Changes to our infrastructure or project setup label Jul 28, 2022
@xDivisionByZerox xDivisionByZerox self-assigned this Jul 28, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jul 28, 2022
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Jul 29, 2022
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like that you rework the template based on my suggestions and then we might have a new feedback cycle

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 self-assigned this Aug 3, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review August 3, 2022 14:42
@Shinigami92 Shinigami92 requested review from ejcheng and ST-DDT August 3, 2022 14:43
Shinigami92
Shinigami92 previously approved these changes Aug 3, 2022
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
ejcheng
ejcheng previously approved these changes Aug 3, 2022
@Shinigami92 Shinigami92 requested review from a team August 3, 2022 15:59
pkuczynski
pkuczynski previously approved these changes Aug 3, 2022
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
@Shinigami92 Shinigami92 dismissed stale reviews from pkuczynski, ejcheng, and themself via d22426e August 4, 2022 06:33
@Shinigami92 Shinigami92 requested a review from ST-DDT August 4, 2022 06:36
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 4, 2022 08:07
@Shinigami92
Copy link
Member

I count the previous approvals as valid, as nothing changed heavily anymore

@Shinigami92 Shinigami92 merged commit 407466f into main Aug 4, 2022
@ST-DDT ST-DDT deleted the workflow/issue-templates/bug-report branch August 12, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants