Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locales.pl): add pl translation for gender and binary gender #1162

Merged
merged 12 commits into from
Jul 26, 2022

Conversation

hankucz
Copy link
Contributor

@hankucz hankucz commented Jul 18, 2022

No description provided.

@hankucz hankucz requested a review from a team as a code owner July 18, 2022 19:19
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1162 (9d475b0) into main (ca7cde5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2146     2148    +2     
  Lines      230499   230530   +31     
  Branches      979      980    +1     
=======================================
+ Hits       229683   229717   +34     
+ Misses        795      792    -3     
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/pl/name/binary_gender.ts 100.00% <100.00%> (ø)
src/locales/pl/name/gender.ts 100.00% <100.00%> (ø)
src/locales/pl/name/index.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

Shinigami92
Shinigami92 previously approved these changes Jul 18, 2022
ST-DDT
ST-DDT previously approved these changes Jul 19, 2022
src/locales/pl/name/gender.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Jul 20, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Jul 20, 2022
@ST-DDT ST-DDT requested review from a team July 20, 2022 09:07
@hankucz hankucz dismissed stale reviews from ST-DDT and Shinigami92 via 4d65ac1 July 20, 2022 09:38
pkuczynski
pkuczynski previously approved these changes Jul 20, 2022
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unrelated commits/reverts from this PR by either rebasing/squashing and filtering the commits.

@pkuczynski
Copy link
Member

Whats the difference? We will squash on merge anyway, right?

@ST-DDT
Copy link
Member

ST-DDT commented Jul 21, 2022

Yes, but I'm referring to this commit, that is in the history but shouldn't be:
faker-js/faker@b1cb83d (#1162) - Revert "chore(linting): add naming convention rule (faker-js#1170)"

The last one in the screenshot:

grafik

.eslintrc.js Outdated Show resolved Hide resolved
src/modules/date/index.ts Outdated Show resolved Hide resolved
src/modules/name/index.ts Outdated Show resolved Hide resolved
@hankucz
Copy link
Contributor Author

hankucz commented Jul 26, 2022

All unnecessary changes have been reverted. @ST-DDT @Shinigami92 could you please re-review and merge?

@hankucz
Copy link
Contributor Author

hankucz commented Jul 26, 2022

The current build failure is the timeout in test/scripts/apidoc/examplesAndDeprecations.spec.ts, which is not related to my PR. I am not sure if I have to do anything about it?

@xDivisionByZerox
Copy link
Member

The current build failure is the timeout in test/scripts/apidoc/examplesAndDeprecations.spec.ts, which is not related to my PR. I am not sure if I have to do anything about it?

I opened an issue for it (#1193) since I struggle with it as well.

@ST-DDT ST-DDT enabled auto-merge (squash) July 26, 2022 21:56
@ST-DDT ST-DDT merged commit 22a050e into faker-js:main Jul 26, 2022
@hankucz hankucz deleted the gender-pl branch August 3, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants