-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locales.en): extend vehicle #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change the commit message?
You have a preference ? |
Please don't use exclamation marks ("!") in your commit messages if they are not introducing a breaking change (even if they had to be in another location). Please also note that smilies are generally considered unprofessionally for commit messages (you can still write them in GitHub comments, tho). |
The new commit message should be fine as well, IMO. |
Please update the test expectation snapshots. To do that run the test script in your project with the update flag |
Codecov Report
@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
- Coverage 99.65% 99.64% -0.01%
==========================================
Files 2146 2146
Lines 230393 230395 +2
Branches 981 977 -4
==========================================
- Hits 229589 229579 -10
- Misses 783 795 +12
Partials 21 21
|
No description provided.