Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locales.en): extend vehicle #1102

Merged
merged 2 commits into from
Jul 1, 2022
Merged

feat(locales.en): extend vehicle #1102

merged 2 commits into from
Jul 1, 2022

Conversation

duvall
Copy link
Contributor

@duvall duvall commented Jun 22, 2022

No description provided.

@duvall duvall requested a review from a team as a code owner June 22, 2022 14:13
prisis
prisis previously requested changes Jun 22, 2022
Copy link
Member

@prisis prisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the commit message?

@duvall
Copy link
Contributor Author

duvall commented Jun 22, 2022

Can you please change the commit message?

You have a preference ?

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Jun 22, 2022

Please don't use exclamation marks ("!") in your commit messages if they are not introducing a breaking change (even if they had to be in another location). Please also note that smilies are generally considered unprofessionally for commit messages (you can still write them in GitHub comments, tho).
Last but not least, your commit message should caption what you did in this commit. In your case "feat(locales.en): extend vehicle" would be a much better fit.

@xDivisionByZerox xDivisionByZerox added c: locale Permutes locale definitions p: 1-normal Nothing urgent labels Jun 22, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jun 22, 2022
@xDivisionByZerox
Copy link
Member

The new commit message should be fine as well, IMO.

@xDivisionByZerox
Copy link
Member

Please update the test expectation snapshots. To do that run the test script in your project with the update flag vitest -u OR delete the according snapshot file (in your case test\__snapshots__\vehicle.spec.ts.snap) and run the basic test script vitest or npm run test. The snapshot file should be updated automatically.

@Shinigami92 Shinigami92 changed the title feat: s3xy Tesla ! :) feat(locales.en): extend vehicle Jun 22, 2022
@Shinigami92 Shinigami92 requested a review from prisis June 22, 2022 15:26
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1102 (b19b327) into main (3519b34) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.01%     
==========================================
  Files        2146     2146              
  Lines      230393   230395       +2     
  Branches      981      977       -4     
==========================================
- Hits       229589   229579      -10     
- Misses        783      795      +12     
  Partials       21       21              
Impacted Files Coverage Δ
src/locales/en/vehicle/model.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 86.37% <0.00%> (-3.48%) ⬇️

@Shinigami92 Shinigami92 enabled auto-merge (squash) June 22, 2022 17:23
@Shinigami92 Shinigami92 merged commit 07a970f into faker-js:main Jul 1, 2022
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@duvall duvall deleted the patch-1 branch August 25, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants