refactor(name.findName): allow prefix and suffix #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
Codecov Report
@@ Coverage Diff @@
## main #1080 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2146 2146
Lines 230380 230380
Branches 979 979
=======================================
Hits 229569 229569
Misses 790 790
Partials 21 21
|
ST-DDT
previously approved these changes
Jun 17, 2022
Shinigami92
previously approved these changes
Jun 18, 2022
xDivisionByZerox
dismissed stale reviews from Shinigami92 and ST-DDT
via
bbd4be3
xDivisionByZerox
force-pushed
the
chore/name/find-name/remove-switch-fallthrough
branch
from
bae5cf0
to
bbd4be3
Compare
Shinigami92
approved these changes
Jun 18, 2022
ST-DDT
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the behavior of
faker.name.findName()to possible return a full name withprefixANDsuffix.This also fixes a to-do list in #1044 about the unwanted fallthrough in the switch statement.