Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renovate pl locales #1055

Merged
merged 4 commits into from
Jun 18, 2022
Merged

Conversation

rybaczewa
Copy link
Contributor

Update polish locale

address

  • update building_number with small letter and slash numbers, popular in Poland
  • remove disambiguations from duplicates in city_name - they are not used in actual addresses
  • update country with recently changed names (Suazi and Macedonia) and remove some artifacts from some kind of copy-paste
  • localize secondary_address
  • update state - polish Voivodships are written starting with lowercase letter. Update state_abbr as well.

color

  • add human

company

  • fix typo in file name adjetive -> adjective

music

  • add genre
  • add song_name

science

  • add chemicalElement
  • add unit

team

  • add name
  • add prefix

@rybaczewa rybaczewa requested a review from a team as a code owner June 11, 2022 00:29
@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jun 11, 2022
@import-brain import-brain added this to the v7 - Current Major milestone Jun 11, 2022
@import-brain import-brain requested a review from a team June 11, 2022 02:01
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #1055 (909693c) into main (77c609e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             main    #1055     +/-   ##
=========================================
  Coverage   99.64%   99.64%             
=========================================
  Files        2135     2146     +11     
  Lines      229240   230380   +1140     
  Branches      979      979             
=========================================
+ Hits       228429   229569   +1140     
  Misses        790      790             
  Partials       21       21             
Impacted Files Coverage Δ
src/locales/pl/company/adjective.ts 100.00% <ø> (ø)
src/locales/pl/address/building_number.ts 100.00% <100.00%> (ø)
src/locales/pl/address/city_name.ts 100.00% <100.00%> (ø)
src/locales/pl/address/country.ts 100.00% <100.00%> (ø)
src/locales/pl/address/secondary_address.ts 100.00% <100.00%> (ø)
src/locales/pl/address/state.ts 100.00% <100.00%> (ø)
src/locales/pl/address/state_abbr.ts 100.00% <100.00%> (ø)
src/locales/pl/color/human.ts 100.00% <100.00%> (ø)
src/locales/pl/color/index.ts 100.00% <100.00%> (ø)
src/locales/pl/company/index.ts 100.00% <100.00%> (ø)
... and 11 more

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Jun 14, 2022
@ST-DDT ST-DDT requested a review from a team June 14, 2022 09:15
@Shinigami92 Shinigami92 enabled auto-merge (squash) June 18, 2022 14:32
@Shinigami92 Shinigami92 merged commit a0d7191 into faker-js:main Jun 18, 2022
@rybaczewa rybaczewa deleted the pl-locale-update branch June 20, 2022 12:08
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added m: location Something is referring to the location module m: color Something is referring to the color module m: company Something is referring to the company module m: music Something is referring to the music module m: science Something is referring to the science module labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: color Something is referring to the color module m: company Something is referring to the company module m: location Something is referring to the location module m: music Something is referring to the music module m: science Something is referring to the science module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants