Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: science module #1014

Merged
merged 31 commits into from
Jun 5, 2022
Merged

feat: science module #1014

merged 31 commits into from
Jun 5, 2022

Conversation

import-brain
Copy link
Member

@import-brain import-brain commented May 27, 2022 •
edited
Loading

closes #944

@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent labels May 27, 2022
@import-brain import-brain added this to the v7 - Current Major milestone May 27, 2022
@import-brain import-brain requested review from a team May 27, 2022 20:28
@import-brain import-brain self-assigned this May 27, 2022
@import-brain import-brain requested a review from a team as a code owner May 27, 2022 20:28
@import-brain import-brain marked this pull request as draft May 27, 2022 20:34
ST-DDT
ST-DDT requested changes May 28, 2022
View reviewed changes
src/definitions/science.ts Outdated Show resolved Hide resolved
src/definitions/science.ts Outdated Show resolved Hide resolved
src/modules/science/index.ts Outdated Show resolved Hide resolved
src/modules/science/index.ts Outdated Show resolved Hide resolved
src/modules/science/index.ts Outdated Show resolved Hide resolved
pkuczynski
pkuczynski requested changes May 29, 2022
View reviewed changes
src/modules/science/index.ts Outdated Show resolved Hide resolved
src/modules/science/index.ts Outdated Show resolved Hide resolved
src/modules/science/index.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 requested changes May 30, 2022
View reviewed changes
src/modules/science/index.ts Outdated Show resolved Hide resolved
src/modules/science/index.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 requested changes May 30, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to re-export the interfaces ChemicalElement and Unit in src/index.ts

@import-brain import-brain added the needs test More tests are needed label May 30, 2022
@import-brain import-brain marked this pull request as ready for review May 31, 2022 17:44
ST-DDT
ST-DDT requested changes May 31, 2022
View reviewed changes
src/modules/science/index.ts Outdated Show resolved Hide resolved
src/locales/en/science/chemicalElement.ts Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes May 31, 2022
View reviewed changes
Shinigami92
Shinigami92 reviewed Jun 1, 2022
View reviewed changes
test/science.spec.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 enabled auto-merge (squash) June 5, 2022 10:19
@Shinigami92 Shinigami92 merged commit d75d079 into main Jun 5, 2022
@Shinigami92 Shinigami92 deleted the science branch June 6, 2022 19:13
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@import-brain @ST-DDT
@Shinigami92 @pkuczynski @Minozzzi
feat: science module (faker-js#1014)
7f7b3ec 
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: Shinigami <[email protected]>
Co-authored-by: pkuczynski <[email protected]>
@xDivisionByZerox xDivisionByZerox added the m: science Something is referring to the science module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@import-brain import-brain

Labels
c: feature Request for new feature m: science Something is referring to the science module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

Science module
5 participants
@import-brain @pkuczynski @ST-DDT @Shinigami92 @xDivisionByZerox