-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove helpers.userCard() from README.md #1013
chore: remove helpers.userCard() from README.md #1013
Conversation
I also had this in mind, but we may want to replace it with e.g. the Alternatively we could remove the whole section and just refer to the docs 🤔 |
True, true. IMO it is better if we leave the example there - it helps with discoverability, and then the user can look into the docs for more helper methods. Also the docs link is not very prominent (I think would be nice if the link was moved to the header, next to the stackblitz link). |
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 2115 2115
Lines 227025 227025
Branches 983 982 -1
==========================================
- Hits 226280 226277 -3
- Misses 725 728 +3
Partials 20 20
|
Added |
Related to #528 and #543. Since the
helpers.*Card
methods were deprecated we need to remove the example fromREADME.md
.