-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check whether the locale data should use locale aware sorting #2905
Comments
Blocked by the initial sorting of the locale data after #2265 |
Potentially relevant implementation details in #2265 (comment).
|
i tried a draft implementation at #2906 - this is imperfect, but gives you an idea of the scope of the likely changes if this is done. |
Team Decision The current locale unaware sorting is good enough/the best approach for our contributor experience. We will add a comment to the script similar to this one:
faker/scripts/generate-locales.ts Lines 300 to 301 in a5ffca1
|
I did some research, digged down the rabbit-hole and found a bit out about ICU so FFR, here is a list of helpful links:
This could be used to download the icu.dat file and store it in some cached way locally and pinned for execution when sorting However I dont have the time right now, so it is just a way and idea and up for experimental grab if someone cares 🙂 |
Done: |
We should check whether the locale data should be sorted with their original locale in mind.
faker/scripts/generate-locales.ts
Line 301 in 7fb9bb5
The text was updated successfully, but these errors were encountered: