Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: ST-DDT <[email protected]>
  • Loading branch information
Shinigami92 and ST-DDT authored Feb 9, 2024
1 parent 79c9137 commit 422c4d4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/modules/finance.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ describe('finance', () => {
it('should set a specified length', () => {
let expected = faker.number.int(20);

Check failure on line 206 in test/modules/finance.spec.ts

View workflow job for this annotation

GitHub Actions / TS-Check: node-20, ubuntu-latest

Cannot redeclare block-scoped variable 'expected'.

expected ||= 4;
const expected = faker.number.int(20) || 4;

Check failure on line 208 in test/modules/finance.spec.ts

View workflow job for this annotation

GitHub Actions / TS-Check: node-20, ubuntu-latest

Cannot redeclare block-scoped variable 'expected'.

const mask = faker.finance.mask(expected, false, false); // the length of mask picks 4 if the random number generator picks 0

Expand Down Expand Up @@ -239,7 +239,7 @@ describe('finance', () => {
it('should set a specified length', () => {
let expected = faker.number.int(20);

Check failure on line 240 in test/modules/finance.spec.ts

View workflow job for this annotation

GitHub Actions / TS-Check: node-20, ubuntu-latest

Cannot redeclare block-scoped variable 'expected'.

expected ||= 4;
const expected = faker.number.int(20) || 4;

Check failure on line 242 in test/modules/finance.spec.ts

View workflow job for this annotation

GitHub Actions / TS-Check: node-20, ubuntu-latest

Cannot redeclare block-scoped variable 'expected'.

const mask = faker.finance.maskedNumber({
length: expected,
Expand Down

0 comments on commit 422c4d4

Please sign in to comment.