Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: individual and group closing dates #99

Merged
merged 1 commit into from
May 30, 2021
Merged

Conversation

mmarchois
Copy link
Contributor

@mmarchois mmarchois commented May 30, 2021

⚠️ this PR introduce BC breaks. Please remove old database

@mmarchois mmarchois self-assigned this May 30, 2021
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #99 (4bc0f2b) into master (c760687) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 4bc0f2b differs from pull request most recent head 3b7d5cb. Consider uploading reports for the commit 3b7d5cb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   92.68%   92.73%   +0.05%     
==========================================
  Files         193      194       +1     
  Lines        1845     1859      +14     
  Branches       68       68              
==========================================
+ Hits         1710     1724      +14     
  Misses        135      135              
Impacted Files Coverage Δ
...hool/Query/Shooting/GetShootingByIdQueryHandler.ts 100.00% <ø> (ø)
...astructure/School/Repository/ShootingRepository.ts 35.71% <ø> (ø)
...n/School/Command/Shooting/CreateShootingCommand.ts 100.00% <100.00%> (ø)
...l/Command/Shooting/CreateShootingCommandHandler.ts 100.00% <100.00%> (ø)
...n/School/Command/Shooting/UpdateShootingCommand.ts 100.00% <100.00%> (ø)
...l/Command/Shooting/UpdateShootingCommandHandler.ts 100.00% <100.00%> (ø)
...Query/Shooting/GetShootingsBySchoolQueryHandler.ts 100.00% <100.00%> (ø)
...src/Application/School/View/ShootingSummaryView.ts 100.00% <100.00%> (ø)
api/src/Application/School/View/ShootingView.ts 100.00% <100.00%> (ø)
api/src/Domain/School/Shooting.entity.ts 97.77% <100.00%> (+0.27%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c760687...3b7d5cb. Read the comment docs.

@mmarchois mmarchois force-pushed the feat/shooting-dates branch from 4bc0f2b to 3b7d5cb Compare May 30, 2021 14:28
@mmarchois mmarchois merged commit 3b6dad8 into master May 30, 2021
@mmarchois mmarchois deleted the feat/shooting-dates branch May 30, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant