Dev message based graph #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Čukić <[email protected]>
Signed-off-by: Ivan Čukić <[email protected]>
|
|
ivan-cukic
force-pushed
the
dev-message-based-graph
branch
3 times, most recently
from
1e0b01e to
e8b920c
Compare
ivan-cukic
force-pushed
the
dev-message-based-graph
branch
from
e8b920c to
d5b3061
Compare
PR produced different images:chart_0001.pngGot:
Expected:
Diff:
|
ivan-cukic
force-pushed
the
dev-message-based-graph
branch
from
e7d7f18 to
b624e4d
Compare
RalphSteinhagen
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
@ivan-cukic thanks for this PR. This looks functionally OK.
There are some minor change requests outlined in more detail above, notably:
- please follow the CORE_NAMING_GUIDELINE notably for new fields/classes. This helps synchronising the style and code-base with GR4
fmt::print[ln](..)debugging messages should be either be deleted, replaced with the new UI popups, or explicitly fowarded (e.g. usingstd::expected) to the calling function.- There are some 'TODO' that should be a bit more explicit and probably be complemented with an issue outlining what needs to be done. The mere TODO comment isn't helpful for the other devs.
- DSO signing missing
Once addressed, this PR could be merged as-is without further review.
ivan-cukic
force-pushed
the
dev-message-based-graph
branch
from
4cf6c61 to
28b670b
Compare
ivan-cukic
force-pushed
the
dev-message-based-graph
branch
2 times, most recently
from
afdbf76 to
4cba1d5
Compare
ivan-cukic
force-pushed
the
dev-message-based-graph
branch
from
4cba1d5 to
e102e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.