Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gnuradio4 main #241

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Bump gnuradio4 main #241

merged 1 commit into from
Nov 15, 2024

Conversation

dantti
Copy link
Contributor

@dantti dantti commented Nov 13, 2024

No description provided.

Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can be merged once the CI passes.

@wirew0rm
Copy link
Member

It blocks in qa_chart with a chart window open also locally and deterministically:
image

It might also be useful to add a timeout to the test CI step, probably the UI testing makes it more probable for the tests to get stuck and it would probably be reasonable to fail the test early after like 10 minutes to get early feedback: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes

Fixes tests and unify dependencies SHAs

Signed-off-by: Daniel Nicoletti <[email protected]>
Copy link

PR produced different images:

chart_0001.png

Got:

chart_0001.png

Expected:

chart_0001.png

Diff:

chart_0001.png

@wirew0rm wirew0rm merged commit f0134ec into main Nov 15, 2024
6 of 7 checks passed
@wirew0rm wirew0rm deleted the dantti/update_gr branch November 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants