cmake: Add an intermediate static library to share code with tests #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the tests to simply link to the library instead of rebuilding ui/ code (per each test executable). Also nice to not have to figure out ui/*cpp dependencies in each test Signed-off-by: Sergio Martins <[email protected]>
PR produced different images:popup_menu_0001.pngGot:
Expected:
Diff:
|
Very interesting, window position is flaky, wondering if it depends on mouse cursor at startup. |
RalphSteinhagen
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the tests to simply link to the library instead of rebuilding ui/ code (per each test executable).
Also nice to not have to figure out ui/*cpp dependencies in each test