Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler class for scheduler/block profiling #131

Merged
merged 18 commits into from
Aug 30, 2023
Merged

Profiler class for scheduler/block profiling #131

merged 18 commits into from
Aug 30, 2023

Conversation

frankosterfeld
Copy link
Contributor

@frankosterfeld frankosterfeld commented Jul 18, 2023 •
edited
Loading

No description provided.

@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 12:57 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld marked this pull request as draft July 18, 2023 12:57
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage July 18, 2023 14:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 28, 2023 15:24 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 30, 2023 13:13 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

9.2% 9.2% Coverage
0.4% 0.4% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

wirew0rm
wirew0rm approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@wirew0rm wirew0rm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Looks good now, thanks. Now the next steps should be adding more metrics to the schedulers and also adding some counters like buffer utilisation.

@wirew0rm wirew0rm merged commit ff0a9ea into main Aug 30, 2023
15 of 19 checks passed
@wirew0rm wirew0rm deleted the frank/profiler branch August 30, 2023 16:24
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 31, 2023 09:01 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 31, 2023 09:01 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 31, 2023 09:01 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 31, 2023 09:01 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 31, 2023 09:01 — with GitHub Actions Inactive
@frankosterfeld frankosterfeld temporarily deployed to configure coverage August 31, 2023 09:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirew0rm wirew0rm wirew0rm approved these changes

@ivan-cukic ivan-cukic Awaiting requested review from ivan-cukic

@RalphSteinhagen RalphSteinhagen Awaiting requested review from RalphSteinhagen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frankosterfeld @wirew0rm