Remove _dropck flag from SendError
#19
Conversation
|
Could this be modified to just remove the comment and explain instead that we'll need something like this if a |
There was a problem hiding this comment.
Looks good overall. Please also remove the _dropck field from Sender and Receiver then. They shoud be equally not needed.
I don't think we need to drag these along just in case #[may_dangle] becomes a thing. Because if that becomes a thing I'm assuming it would be opt in, and any such opting in would need to make sure the ownership is correctly marked at that point.
|
Looks like you force pushed a new commit that is identical? |
The nomicon has been outdated about this since 2015, see rust-lang/nomicon#363 for the update. We don't need to tell dropck that we are owning a T as it can already infer that from the generic parameter in the drop impl.
|
oh |
|
Thank you for the contribution! |
|
Aah. It should have been removed from the changelog as well! https://github.com/faern/oneshot/blob/3cee01f3ff91afa7691357494f87cbd3d2727446/CHANGELOG.md#fixed I'll do that directly. |
The nomicon has been outdated about this since 2015,
see rust-lang/nomicon#363 for the update.
We don't need to tell dropck that we are owning a T as it
can already infer that from the generic parameter in the drop impl.
cc @Cassy343 who added it