Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default setting for timeout is too low #26

Closed
fadhilyori opened this issue Jul 10, 2023 · 0 comments · Fixed by #31
Closed

The default setting for timeout is too low #26

fadhilyori opened this issue Jul 10, 2023 · 0 comments · Fixed by #31
Labels
bug Something isn't working
Milestone
Version 1.0.0 Rel...

Comments

@fadhilyori
Copy link
Owner

Describe the bug
Default timeout (80 ms) is too low, sometimes IPs are not discovered consistently.

To Reproduce
Steps to reproduce the behavior:

  1. Use the default settings for subping (without the flag)

Expected behavior
Timeout -t 1s is more stable and detects more IP consistently.
@fadhilyori fadhilyori added the bug Something isn't working label Jul 10, 2023
fadhilyori added a commit that referenced this issue Jul 24, 2023
@fadhilyori
fix: increase default timeout #26
da6da3b
fadhilyori added a commit that referenced this issue Jul 24, 2023
@fadhilyori
fix: increase default timeout #26 (#31)
7a1d67f
@fadhilyori fadhilyori linked a pull request Jul 24, 2023 that will close this issue
fix: increase default timeout #26 #31
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.0.0 Release
1 participant
@fadhilyori