This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Fix ReadFromBuffer() for empty strings in debug mode #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the string to be read is empty (
string_size == 0
) and the package that includes this header is compiled in debug mode, then this assertion inSpan::operator[]
can fail becausebuffer[offset]
would access the span past its boundaries if this is the last element in the buffer.I assume that the implementations of
std::string::assign(buffer_ptr, string_size)
ignore thebuffer_ptr
ifstring_size == 0
, but better to handle this case separately...Edit: Actually it is not an assertion and span.hpp defines its own macros for checking contracts and either throw exceptions or terminate, but the result is the same.