BUGFIX: Parsing of Diagnostic Status Msg #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version, DataLoadRos2 throws a "Not Enough Memory in the Buffer Stream" Error when Loading
a
diagnostic_msgs/DiagnosticStatus.msgfrom a rosbag.This is IMO caused by typo while creating the specialized ros parsers. In there, the DiagnosticArray is mixed up with up the DiagnosticStatus message. As a result, the diagnostic status is tried to be deserialized as DiagnosticArray, which throws the aforementioned Exception.
Switching to the correct msg type fixes the issue for me.