Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing '22' in the new snap core22 workflow #870

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

MirkoFerrati
Copy link
Contributor

I am very sorry I missed that line when preparing the core22 snap workflow.
Note that the store credentials need a refresh as described in https://github.com/facontidavide/PlotJuggler/actions/runs/6254336114/job/16982529217

Exported credentials are no longer valid for the Snap Store.
Recommended resolution: Run export-login and update SNAPCRAFT_STORE_CREDENTIALS.
For more information, check out: https://snapcraft.io/docs/snapcraft-authentication

So even with this fix the above secret has to be taken care of by @facontidavide directly in the secrets.STORE_LOGIN

@facontidavide facontidavide merged commit ab86956 into facontidavide:main Sep 20, 2023
15 checks passed
@facontidavide
Copy link
Owner

snap publish is red

@MirkoFerrati
Copy link
Contributor Author

@facontidavide the new snapcraft requires a refresh of the login credentials.
https://snapcraft.io/docs/snapcraft-authentication
I am pretty sure you can fix the error if you put inside the secrets STORE_LOGIN the value exported in the credentials.txt file created by running
snapcraft export-login credentials.txt and providing your snapcraft login/password.
I had to do the same in one of my repos few weeks ago for the same error.
image

@facontidavide
Copy link
Owner

Hi,
you may want to have a look at this error: https://github.com/facontidavide/PlotJuggler/actions/runs/7020499580/job/19101465212

Any suggestion?

@MirkoFerrati
Copy link
Contributor Author

Hello and thanks for taking care of the secrets refresh!
I asked for the humble track in the store https://forum.snapcraft.io/t/new-track-for-plotjuggler-humble/37944 and this should fix the failure.
I will check back in a week

@MirkoFerrati
Copy link
Contributor Author

@facontidavide the humble track has been created -> the core22 publish step in CI should work now

@facontidavide
Copy link
Owner

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants