Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Issues with CMake >= 3.26.0 #820

Closed
aschneuw opened this issue May 1, 2023 · 1 comment
Closed

Build Issues with CMake >= 3.26.0 #820

aschneuw opened this issue May 1, 2023 · 1 comment

Comments

@aschneuw
Copy link

aschneuw commented May 1, 2023

Problem description

When building with CMake >= 3.26.0 the dependency build QCodeEditor fails with a compilation error (QT include libraries)

Steps to reproduce (important)

Workaround

Add -std=c++11 to 3rdparty/QCodeEditor/CMakeLists.txt target_compile_options

if(CMAKE_COMPILER_IS_GNUCXX)
target_compile_options(QCodeEditor
PRIVATE
-ansi
-pedantic
-Wall
-Wextra
-Weffc++
-Woverloaded-virtual
-std=c++11
-Winit-self
-Wunreachable-code
)
endif(CMAKE_COMPILER_IS_GNUCXX)

@zdavkeos
Copy link
Contributor

I can confirm the suggested change works. I suggest making a pr.

facontidavide added a commit that referenced this issue May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants