Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block snippet lines render blank code block, when it's just the first line #2361

Closed
shaedrich opened this issue Apr 22, 2024 · 2 comments · Fixed by #2362
Closed

Code block snippet lines render blank code block, when it's just the first line #2361

shaedrich opened this issue Apr 22, 2024 · 2 comments · Fixed by #2362
Labels
S: confirmed Confirmed bug report or approved feature request. T: bug Bug.

Comments

@shaedrich
Copy link

Description

When I embed a snippet in a code snippet, restricting the lines to :1:1, the code block is rendered empty. This can temporarily be fixed by writing ::1 (which should be equivalent), so it's not urgent or anything, but I thought, you might want to fix that.

Minimal Reproduction

  1. Create the following code block:
--8<-- "some-code-snippet-file-path.pony:1:1"
  1. Build your site and check the result for the code block

Version(s) & System Info

  • Operating System: ¯\_(ツ)_/¯
  • Python Version: 3.8
  • Package Version: 10.8
@shaedrich shaedrich added the T: bug Bug. label Apr 22, 2024
@gir-bot gir-bot added the S: triage Issue needs triage. label Apr 22, 2024
@facelessuser
Copy link
Owner

It's actually just a problem with specifying 1 as the start. So even ranges of something like 1:4 will exclude the first line. I know what the issue is and the fix is pretty straight forward.

Thanks for brining this to my attention.

@facelessuser facelessuser added S: confirmed Confirmed bug report or approved feature request. and removed S: triage Issue needs triage. labels Apr 22, 2024
@shaedrich
Copy link
Author

Sounds good, looking forward to it 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: confirmed Confirmed bug report or approved feature request. T: bug Bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants