Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch compile support for ck attention op #1085

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

jianyuh
Copy link
Member

@jianyuh jianyuh commented Aug 24, 2024

What does this PR do?

Add torch.compile support for CK ops , to avoid graph break in pt2 workflow.

From D61453034

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@jianyuh jianyuh requested a review from bottler August 24, 2024 05:56
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2024
@jianyuh jianyuh requested a review from danthe3rd August 24, 2024 05:57
Copy link
Contributor

@danthe3rd danthe3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

at::Tensor out = at::empty({B, M, Hq, Kv}, opts);
int64_t philox_seed = 0;
int64_t philox_offset = 0;
if (!seqstart_q.has_value()) { // input is batched
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this 'if-else' is necessary. When there is no varlen, the batch size is already 1 right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will follow-up: currently making this consistent with fbcode.

@jianyuh jianyuh merged commit 00aba59 into main Aug 26, 2024
10 checks passed
bertmaher pushed a commit to bertmaher/xformers that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants