Fix a condition check on PyPI release workflow #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 1. There was a small bug in the PyPI release workflow where I accidentally inverted the true/false condition on whether a new version should be released or not. 2. However, (1) means that the workflow should've been triggered. The only reason it wasn't is that, by default, the `checkout` action only pull the latest commit without any history... [so using `git tag` in workflow does not return anything](actions/checkout#100) 3. To fix (2), we should use `git ls-remote` to check the existing tags on GitHub (instead of listing the local ones). Cloning the repo with full history also works, but is much less efficient. Differential Revision: D24696408 fbshipit-source-id: 40b28124ccbb412fceb0da8784c888e88dc51f2e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D24696408 |
|
This pull request has been merged in 44b0632. |
facebook-github-bot
pushed a commit
to facebookincubator/flowtorch
that referenced
this pull request
May 14, 2021
Summary: ### Motivation We are bitten by actions/checkout#100 [yet again](facebookresearch/pplbench#52), so lets just fetch the tags during checkout. ### Changes proposed Fetch tags during `actions/checkout` Pull Request resolved: #33 Test Plan: https://github.com/facebookincubator/flowtorch/runs/2586537945?check_suite_focus=true Reviewed By: jpchen, horizon-blue Differential Revision: D28449241 Pulled By: feynmanliang fbshipit-source-id: bf7224961a28fc7b2fd1e4733e519be6e0030590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
checkoutaction only pull the latest commit without any history... so usinggit tagin workflow does not return anythinggit ls-remoteto check the existing tags on GitHub (instead of listing the local ones). Cloning the repo with full history also works, but is much less efficient.This is how it would look like in README.md:
Differential Revision: D24696408