Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Fix centering, scaling and clamping population in ICEMOptimizer.optimize #174

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

marbaga
Copy link
Contributor

@marbaga marbaga commented Jan 18, 2023

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Fixes #172.

How Has This Been Tested (if it applies)

No additional test was added, default tests passed.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2023
@luisenp luisenp self-requested a review January 19, 2023 20:16
@luisenp
Copy link
Contributor

luisenp commented Jan 19, 2023

Thanks for the pull request! Looks good. Can you rebase on top of main, fixed some format errors that were breaking CI. Good to merge after that.

@luisenp luisenp merged commit 0f2b773 into facebookresearch:main Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Centering, scaling and clamping the population in iCEM
3 participants