Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

PID code and Update Readme #165

Merged
merged 25 commits into from
Sep 12, 2022
Merged

Conversation

natolambert
Copy link
Contributor

The minimum changes to get a notebook running for #158.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2022
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to fix some CI errors. Thanks for adding this!

@natolambert
Copy link
Contributor Author

Ah, oops. Will come back to this within a couple days!

@natolambert
Copy link
Contributor Author

@luisenp should be good? Its annoying to run the pre-commits hardcoded to 3.7 with conda no longer supporting it. Looking forward to that update being merged into main :)

@luisenp luisenp merged commit 7dbca52 into facebookresearch:main Sep 12, 2022
@luisenp
Copy link
Contributor

luisenp commented Sep 12, 2022

Merged! Thanks for the contribution @natolambert!

@natolambert
Copy link
Contributor Author

Awesome, excited to finally be listed as a contributor. I hope to continue in the future!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants