Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Fix Hydra warning by sticking to OmegaConf 2.0.x #157

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

odelalleau
Copy link
Contributor

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

The deprecation of OmegaConf.is_none() in OmegaConf 2.1 causes a warning
with Hydra 1.0.x. The fix consists in using an older version of
OmegaConf.

How Has This Been Tested (if it applies)

python -m pytest tests/core
python -m pytest tests/algorithms

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

The deprecation of OmegaConf.is_none() in OmegaConf 2.1 causes a warning
with Hydra 1.0.x. The fix consists in using an older version of
OmegaConf.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2022
@luisenp luisenp merged commit 94b76e7 into facebookresearch:main Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants