Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Change SAC library to use the implementation written by pranz24 #142

Merged
merged 27 commits into from
Feb 3, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 10, 2022

Types of changes

Investigates the performance of MBPO when using this SAC implementation.

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

As mentioned in #138, this library is reported to have better results than the one used previously.

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.
  • Test on all domains to see if it works better than previous implementation.
  • Tune hyperparameters for new implementation.
  • Update CHANGELOG

@luisenp luisenp self-assigned this Jan 10, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2022
@luisenp luisenp marked this pull request as ready for review January 17, 2022 22:23
@luisenp
Copy link
Contributor Author

luisenp commented Jan 24, 2022

From my first runs, the new SAC library improves results in cheetah and inverted pendulum, but not in the other domains yet. See plots below and compare with our results in the paper (still lower than orig. MBPO, but better than before).

imageimage

I didn't individually tune for all domains, do that's the next thing I'll try.

@luisenp luisenp force-pushed the change_sac_library branch from 1f5b32c to 84d19d8 Compare January 28, 2022 10:12
@luisenp luisenp merged commit 4543fc9 into main Feb 3, 2022
@luisenp luisenp deleted the change_sac_library branch February 3, 2022 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants