This repository has been archived by the owner on Sep 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 156
Change SAC library to use the implementation written by pranz24 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 10, 2022
From my first runs, the new SAC library improves results in cheetah and inverted pendulum, but not in the other domains yet. See plots below and compare with our results in the paper (still lower than orig. MBPO, but better than before). I didn't individually tune for all domains, do that's the next thing I'll try. |
luisenp
force-pushed
the
change_sac_library
branch
from
January 28, 2022 10:12
1f5b32c
to
84d19d8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Investigates the performance of MBPO when using this SAC implementation.
Motivation and Context / Related issue
As mentioned in #138, this library is reported to have better results than the one used previously.
How Has This Been Tested (if it applies)
Checklist