This repository has been archived by the owner on Sep 1, 2024. It is now read-only.
Changed signature of reset and sample methods to use a model state dictionary #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Model.reset()
andModel.sample()
signature has changed. They no longer receiveTransitionBatch
objects, and they both return a dictionary of strings to tensorsrepresenting a model state that should be passed to
sample()
to simulatetransitions. This dictionary can contain things like previous actions, predicted
observation, latent states, beliefs, and any other such quantity that the model
need to maintain to simulate trajectories when using
ModelEnv
.Ensemble
class and sub-classes are assumed to operate on 1-D models.Motivation and Context / Related issue
This change facilitates some of the work necessary to complete the PlaNet implementation in #86, and should allow more flexibility in the types of models that can be simulated with
ModelEnv
.How Has This Been Tested (if it applies)
All unit tests pass and PETS notebook runs correctly.
Checklist