This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Bugfix: incorrect BACKBONE_OUT_CHANNELS due to duplicate RESNET keys in yaml files #545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some YAML files the RESNETS key appears twice.
yacs
usespyyaml.safe_load()
, which considers only the last key occurrence.In the adapted configs, this means that instead of the specified 256 channels the models were actually trained with the default 1024 channels.
Imho yacs should throw an error in case of duplicate keys, as requested in an open bug report in pyyaml: yaml/pyyaml#165
I will create an issue within
yacs
to point to that issue.