Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Update .gitignore #4

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Update .gitignore #4

merged 2 commits into from
Oct 25, 2018

Conversation

Jiayuan-Gu
Copy link

No description provided.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

fmassa
fmassa suggested changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!
I have only a minor comment, and then this is good to go!

.gitignore Outdated
@@ -3,6 +3,7 @@ __pycache__
_ext
*.pyc
*.so
# TODO: unify name
torch_detectron.egg-info/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you for the moment update this to be maskrcnn_benchmark, and delete the line below, which is not needed anymore?

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 25, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fmassa fmassa merged commit 9c51449 into facebookresearch:master Oct 25, 2018
@fmassa
Copy link
Contributor

fmassa commented Oct 25, 2018

Thanks a lot!

@ll490187880 ll490187880 mentioned this pull request Oct 26, 2018
Closed
@engineer1109 engineer1109 mentioned this pull request Dec 20, 2018
Open
@jordanxlj jordanxlj mentioned this pull request Dec 25, 2018
Open
@rudgerte rudgerte mentioned this pull request Mar 1, 2019
Open
@mitsuix mitsuix mentioned this pull request Mar 17, 2019
Closed
@zhongyingji zhongyingji mentioned this pull request Mar 28, 2019
Open
@dedoogong dedoogong mentioned this pull request Aug 16, 2019
Open
@Jacobew Jacobew mentioned this pull request Apr 19, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiayuan-Gu @facebook-github-bot @fmassa