Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra.utils.instantiate() : allow passthrough of non primitive objects by name #404

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

omry
Copy link
Collaborator

@omry omry commented Feb 10, 2020

Closes #400

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2020
@omry
Copy link
Collaborator Author

omry commented Feb 10, 2020

unfortunately this depends on some other fix I have in another branch that is not ready yet.
I will land it later.

@omry omry force-pushed the 400 branch 2 times, most recently from fe90b66 to f55cdef Compare February 27, 2020 03:59
@omry omry merged commit 3d7c86f into master Feb 27, 2020
@omry omry deleted the 400 branch February 27, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] issues with named arguments in hydra.utils.instantiate
2 participants