unpin mypy #1878
Merged
unpin mypy #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Related to the above CI failure on commit 000c360: |
|
Rebased against |
pixelb
approved these changes
Jan 12, 2022
- check subdirs separately (python/mypy#4008) - use mypy flags --install-types --non-interactive - fixup noxfile: use lint_plugins to run mypy on plugins - noxfile: run mypy on tools/ without --strict flag
pixelb
reviewed
Feb 14, 2022
pixelb
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1326
Edit:
I've updated this PR and the tests are now passing.
Commits:
Comments on this diff:
The latest version of mypy errors if it detects multiple modules with the same name (mypy#4008). This means simultaneously checking many files named
my_app.pywill result in a mypy error (assuming that there is no__init__.pynext tomy_app.py). Guido van Rossum commented on mypy#4008, saying "You should really run mypy separately over each package in that case". This motivates many of the changes made in the second and third commits to this PR.