Override grammar: allow question marks in unquoted strings #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
omry
reviewed
May 3, 2021
tests/test_overrides_parser.py
Outdated
Comment on lines
1003
to
1015
| param( | ||
| "key={a%s: 0}" % UNQUOTED_SPECIAL, | ||
| {f"a{UNQUOTED_SPECIAL}": 0}, | ||
| id="dict_key_noquote", | ||
| ), |
There was a problem hiding this comment.
I think the leading a is accidental here.
not sure what value it's adding here. I vote to remove it (and in that case, is this test case already covered?)
There was a problem hiding this comment.
I removed it in 4f89e38 (also rebased on master to fix a conflict)
There is a test that is very similar in test_dict_container() but it doesn't test the same parser rule and doesn't use the .value() method (which seems to be the purpose here).
omry
reviewed
May 3, 2021
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1597