Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for force-add override syntax (++key=value) #1440

Merged
merged 9 commits into from
Mar 3, 2021
Merged

Support for force-add override syntax (++key=value) #1440

merged 9 commits into from
Mar 3, 2021

Conversation

omry
Copy link
Collaborator

@omry omry commented Mar 2, 2021

Closes #1049

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2021
@omry omry requested review from jieru-hu and odelalleau March 2, 2021 22:07
odelalleau
odelalleau requested changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, I suspect that get_key_element() intypes.py also needs to be updated, could you have a look and add a test for it?

@omry
Copy link
Collaborator Author

omry commented Mar 2, 2021

Just one thing, I suspect that get_key_element() intypes.py also needs to be updated, could you have a look and add a test for it?

nice catch.

odelalleau
odelalleau approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good once CI gives the green light!

@kenahoo
Copy link

kenahoo commented Mar 2, 2021

I tested this for my use case, it seems to work well. Thanks for looking at it.

@Gpapi13
Copy link

Gpapi13 commented Mar 3, 2021

  • [ ]

@omry omry merged commit e8b45f8 into master Mar 3, 2021
@omry omry deleted the force_add branch March 3, 2021 18:16
@omry omry mentioned this pull request Apr 1, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odelalleau odelalleau odelalleau approved these changes

@jieru-hu jieru-hu Awaiting requested review from jieru-hu

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OR Override-if-exists
5 participants
@omry @kenahoo @Gpapi13 @odelalleau @facebook-github-bot