Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Support for Positional Only Arguments and Varadic Arguments #1438

Closed
wants to merge 3 commits into from
Closed

Conversation

monney
Copy link
Contributor

@monney monney commented Mar 2, 2021

Motivation

To instantiate objects, or call functions, which require positional only arguments or varadic arguments. Examples include tuple and some numpy functions.

Have you read the [Contributing Guidelines on pull requests]

Yes

Test Plan

I added tests to cover core functionality of the new feature. Some more may be needed.

Related Issues and PRs

Adds support requested in #1432 and #808

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2021
@omry
Copy link
Collaborator

omry commented Mar 2, 2021

Thanks @monney.
I will take a closer look in a week or so.

@omry
Copy link
Collaborator

omry commented Mar 11, 2021

Thanks @monney, I am going to take over the PR.
The best way for me to be sure the tests are comprehensive enough is to add the things I think are missing.
I will also update the documentation.

@omry
Copy link
Collaborator

omry commented Mar 11, 2021

Closing in favor of #1470

@omry omry closed this Mar 11, 2021
@monney
Copy link
Contributor Author

monney commented Mar 12, 2021

Thanks @omry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants