-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the configerator config source doc. #1190
Conversation
Cool. @hydra.main(config_path="configerator://my_project", config_name="config")
def main(cfg):
... |
6a963f3
to
142f8b1
Compare
I'm not sure I get this one. We can still read from configerator as primary if the SearchPathPlugin is defined and the config name exists in configerator. (and I've tested that in fbcode it works. ) maybe we can chat about this in person tomorrow. |
142f8b1
to
3d188cb
Compare
I am talking about the situation when we no longer need the SearchPathPlugin because we have the ability to configure the searchpath in the primary config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ah got it! thx for the clarification. |
* Add configerator config source doc
Motivation
Move the doc to hydra doc.
Have you read the Contributing Guidelines on pull requests?
Yes/No
Test Plan
Build it locally, verified it looked ok
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)