Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group plugins in the documentation #1176

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

shagunsodhani
Copy link
Contributor

Motivation

Group plugins in the documentation.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2020
@shagunsodhani
Copy link
Contributor Author

Screen Shot 2020-12-02 at 12 06 18 PM
Screen Shot 2020-12-02 at 12 09 42 PM

@shagunsodhani shagunsodhani requested review from omry and jieru-hu and removed request for omry December 2, 2020 17:10
@omry
Copy link
Collaborator

omry commented Dec 2, 2020

Nice!
Let's ungroup colorlog until we have more misc plugins.
I think this would be a reasonable order (It's just accidentally sorted):

  • colorlog
  • Launchers
  • Sweepers

@shagunsodhani
Copy link
Contributor Author

Screen Shot 2020-12-02 at 4 45 27 PM
Screen Shot 2020-12-02 at 4 45 38 PM

Copy link
Collaborator

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omry omry merged commit c1eb243 into facebookresearch:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants