This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @GoldenCorgi - nice to see you contributing again :)
It looks good to me, let's see what the CI say about it
Yes perfect. Indeed we don't want to add a dependency for end-users, but it's fine to add dev dependencies I'll merge it when the CI is all green. |
danthe3rd
reviewed
Oct 15, 2021
hiplot/test_experiment.py
Outdated
Comment on lines
45
to
47
def objective(trial): | ||
x = trial.suggest_float("x", -1, 1) | ||
return x ** 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some typing here - let's not worry too much about tests typing tho, this should work
Suggested change
def objective(trial): | |
x = trial.suggest_float("x", -1, 1) | |
return x ** 2 | |
def objective(trial: tp.Any) -> float: | |
x = trial.suggest_float("x", -1, 1) | |
return x ** 2 |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 15, 2021
Updated this in the latest commit!
hiplot/hiplot/test_experiment.py Lines 43 to 52 in 9501dbb
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @danthe3rd !
This should work for the integration mentioned in #145
Two key things I'm not too sure about (sorry again! pretty bad at open source contribution)
Is the type checking / type hinting here correct?
2. I added optuna as a dependency for dev & import it during the testing, is this correct?
If everything works out - I'm thinking of implementing this to the other popular hyperparam tuning libraries as well - like HyperOpt & Ray Tune
Thanks!