Merge pull request #206 from facebookresearch/es3

Make HiPlot lib es3-compatible
facebookresearch · Jul 28, 2021 · 99da045 · 99da045
2 parents 0f7d393 + f79a2b4
commit 99da045
Show file tree

Hide file tree

Showing 8 changed files with 1,314 additions and 79 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -314,6 +314,16 @@ jobs:
           paths:
             - built
 
+  npm-test-ES3:
+    docker:
+      - image: node:lts-buster
+    steps:
+      - checkout
+      - attach_workspace:
+          at: npm-package
+      - run: npm install es-check
+      - run: npx es-check es3 npm-package/hiplot/dist/hiplot.lib.js
+
   npm-test:
     docker:
       - image: node:lts-buster
@@ -539,6 +549,12 @@ workflows:
           filters:
             tags:
               only: /.*/
+      - npm-test-ES3:
+          requires:
+            - npm-build
+          filters:
+            tags:
+              only: /.*/
       - mypy_pytest:
           requires:
             - npm-build
@@ -604,6 +620,7 @@ workflows:
           requires:
             - pypi-build
             - npm-build
+            - npm-test-ES3
             - npm-test
             - docs-build
             - browser-jupyter-chrome
@@ -621,6 +638,7 @@ workflows:
           requires:
             - pypi-build
             - npm-build
+            - npm-test-ES3
             - npm-test
             - docs-build
             - browser-jupyter-chrome