Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] - disable new clone protection for git lfs #1961

Merged
merged 1 commit into from
May 16, 2024
Merged

[CI] - disable new clone protection for git lfs #1961

merged 1 commit into from
May 16, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 16, 2024

Motivation and Context

Git LFS was broken on CI by new security measures git-lfs/git-lfs#5749

This PR disables the clone protections for pulling data from our HF repos.

How Has This Been Tested

CI

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 16, 2024
0mdc
0mdc approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3
Copy link
Contributor Author

aclegg3 commented May 16, 2024

Note that I'm seeing checkout issues with the embedded downloader hooks within test_baselines_training.
Maybe the system variable isn't carrying between jobs or this fix doesn't apply through that particular pytest fixture interface abstraction.
In any case, I'll fix that in a follow-up.

@aclegg3 aclegg3 merged commit d4b1e41 into main May 16, 2024
3 of 4 checks passed
@aclegg3 aclegg3 deleted the alex-05_16-fix_ci_data_download branch May 16, 2024 22:53
@aclegg3 aclegg3 mentioned this pull request May 16, 2024
Merged
5 tasks
0mdc pushed a commit that referenced this pull request May 23, 2024
@aclegg3 @0mdc
Disable new clone protection for git lfs (#1961)
a0ab1c2
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@aclegg3 @dannymcy
Disable new clone protection for git lfs (facebookresearch#1961)
ad580fc
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@aclegg3
Disable new clone protection for git lfs (facebookresearch#1961)
17aea70
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@aclegg3 @dannymcy
Disable new clone protection for git lfs (facebookresearch#1961)
17edaa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@xavierpuigf xavierpuigf Awaiting requested review from xavierpuigf

@jimmytyyang jimmytyyang Awaiting requested review from jimmytyyang

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @0mdc @facebook-github-bot