Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add configuration to enable new connections by default. #1960

Merged
merged 1 commit into from
May 17, 2024
Merged

HITL - Add configuration to enable new connections by default. #1960

merged 1 commit into from
May 17, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 16, 2024

Motivation and Context

This adds a new configuration to enable new connections by default.

Use cases:

  • It is on by default.
  • Turn off when creating an application that should not have users connecting immediately after launch.

How Has This Been Tested

Tested locally.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 16, 2024
@0mdc 0mdc merged commit cda0b35 into main May 17, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/allow_new_connections_by_default branch May 17, 2024 17:43
0mdc added a commit that referenced this pull request May 23, 2024
@0mdc
Add configuration to enable new connections by default. (#1960)
4e8650c
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
Add configuration to enable new connections by default. (facebookrese…
99dbc18 
…arch#1960)
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
Add configuration to enable new connections by default. (facebookrese…
f3d2624 
…arch#1960)
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
Add configuration to enable new connections by default. (facebookrese…
90b5e26 
…arch#1960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@zephirefaith zephirefaith Awaiting requested review from zephirefaith

@Ram81 Ram81 Awaiting requested review from Ram81

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @jturner65 @facebook-github-bot